Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return in finally can swallow exception #439

Open
iritkatriel opened this issue Oct 24, 2024 · 0 comments
Open

return in finally can swallow exception #439

iritkatriel opened this issue Oct 24, 2024 · 0 comments

Comments

@iritkatriel
Copy link

In

python-sdk/optimizely/config_manager.py

Line 153 in 40880ff

return
there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if any exception is raised from one of the except: clauses, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iritkatriel