Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native is installed as dependency even if the SDK is meant to be used in NodeJS #697

Closed
fjcero opened this issue Aug 10, 2021 · 4 comments

Comments

@fjcero
Copy link

fjcero commented Aug 10, 2021

How would the enhancement work?

Reduce the size of dependencies

When would the enhancement be useful?

Currently, main issues and bugs are coming from React Native peer-dependencies https://www.npmjs.com/advisories/1769

What I wanted to do

Reduce dependencies when not needed to avoid potential issues

What I expected to happen

Not having React Native when using NodeJS

What actually happened

Steps to reproduce

npm install @optimizely/optimizely-sdk

@midudev
Copy link

midudev commented Sep 28, 2021

Also, this is bloating node_modules with huge not needed dependencies:

CleanShot 2021-09-28 at 15 33 36@2x

@vanderhoop
Copy link

Any movement on this?

@mikechu-optimizely
Copy link
Contributor

mikechu-optimizely commented Aug 24, 2023

I think when we update the "exports" declarations (#836, FSSDK-8983) in the package.json, only the needed deps should come along for the ride into your bundle, shaking out un-need classes.

@raju-opti
Copy link
Contributor

not reproducible with v4.10.0 and v5.0.1. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants