Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package does not comply with PSR-4 #13

Open
mstralka opened this issue Mar 20, 2021 · 3 comments · May be fixed by #15
Open

Package does not comply with PSR-4 #13

mstralka opened this issue Mar 20, 2021 · 3 comments · May be fixed by #15

Comments

@mstralka
Copy link

Beginning with Composer 2.0, classes that do not comply with the PSR-4 naming standard are not autoloaded.

When I try to use this package with Composer 2.0, it shows this warning:

Class org\nameapi\client\fault\HttpResponseData located in ./vendor/optimaize/nameapi-client-php/src/org/nameapi/client/http/HttpResponseData.php does not comply with psr-4 autoloading standard. Skipping.
Class org\nameapi\client\services\riskdetector\riskdetector\PersonRiskDetectorService located in ./vendor/optimaize/nameapi-client-php/src/org/nameapi/client/services/riskdetector/person/PersonRiskDetectorService.php does not comply with psr-4 autoloading standard. Skipping.

This article does a good job explaining that the folder names need to start with uppercase letters.

I will try to fork the library and submit a PR soon unless this change is already under development?
@mstralka mstralka linked a pull request Mar 20, 2021 that will close this issue
Open
@yakushevi
Copy link

@mstralka Thank you for opening this issue, we are waiting for this as well as we're also planning on upgrading to Composer 2.0.
Hopefully the dev will answer soon.

@mstralka
Copy link
Author

@yakushevi you're welcome. I forked and fixed it here if you want to use the fork: https://github.com/mobilelocker/nameapi-client-php

@yakushevi
Copy link

yakushevi commented May 10, 2021 •
edited
Loading

@mstralka I will probably take you on that offer 😉 as it seems that the repo is not maintained...

Edit: Just wanted to say well done on that PR!! I can see you invested your time into it 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored to comply with PSR-4 mobilelocker/nameapi-client-php
2 participants
@mstralka @yakushevi