Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate windows icon #22

Open
jacobtomlinson opened this issue Nov 28, 2018 · 4 comments
Open

Reinstate windows icon #22

jacobtomlinson opened this issue Nov 28, 2018 · 4 comments
Labels
bug

Comments

@jacobtomlinson
Copy link
Member

Had to remove the windows app icon in #20 because of electron/rcedit#56.

We need to find a way of reinstating it.
@AdityaSrivast
Copy link

AdityaSrivast commented May 15, 2019 •
edited
Loading

@jacobtomlinson I would like to work on this issue. Is adding the same line again(--icon=assets/icons/icon.png) resulting in some other issue?

@jacobtomlinson
Copy link
Member Author

Thanks @AdityaSrivast. Honestly I'm not sure, it needs investigating.

@gagandeepp
Copy link
Contributor

I am on it

@notpx
Copy link

notpx commented Mar 1, 2023

I can work on this @jacobtomlinson but can you explain more about it, as I am a bit new here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jacobtomlinson @AdityaSrivast @gagandeepp @notpx