Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --insecure option to 'generate bundle' command #6533

Closed

Conversation

dprince
Copy link

@dprince dprince commented Aug 9, 2023

Add --insecure option to 'bundle generate' command which can be used along with --use-image-digests to produce image digests from insecure registries.

Required a bump to operator-manifest-tools v0.4.0 to obtain the insecure option. Additionally holding at k8s.io/apimachinery 0.26.2 for now as bump to 27.2 (required by latest operator-manifest-tools v0.4.0) would require further ConditionWithContextFunc changes.

Pin apimachinery to fix build (Further changes will be required to support apimachinery 0.27+)

@openshift-ci openshift-ci bot requested review from fabianvf and grokspawn August 9, 2023 00:33
Add --insecure option to 'bundle generate' command which can be used
along with --use-image-digests to produce image digests from insecure
registries.

Required a bump to operator-manifest-tools v0.4.0 to obtain
the insecure option. Additionally holding at k8s.io/apimachinery 0.26.2 for
now as bump to 27.2 (required by latest operator-manifest-tools v0.4.0)
would require further ConditionWithContextFunc changes.

Pin apimachinery to fix build (Further changes will be required to support
apimachinery 0.27+)

Signed-off-by: Dan Prince <[email protected]>
@dprince dprince force-pushed the generate_bundle_insecure branch from c84f30a to b680bee Compare August 9, 2023 11:49
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2023
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 27, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Feb 27, 2024
Copy link

openshift-ci bot commented Feb 27, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants