Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps go/net to v0.33.0 #1522

Merged

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Dec 20, 2024

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (9bb2b1a) to head (ccd7a59).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
+ Coverage   46.79%   46.80%   +0.01%     
==========================================
  Files         135      135              
  Lines       15760    15760              
==========================================
+ Hits         7375     7377       +2     
+ Misses       7345     7342       -3     
- Partials     1040     1041       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bentito, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@grokspawn grokspawn added this pull request to the merge queue Dec 20, 2024
@grokspawn grokspawn removed this pull request from the merge queue due to a manual request Dec 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2024
@grokspawn
Copy link
Contributor

Ugh. Forget that this project still uses prow for merges.

@openshift-merge-bot openshift-merge-bot bot merged commit a0a503e into operator-framework:master Dec 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants