Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replace directive from go.mod #1482

Open
perdasilva opened this issue Oct 30, 2024 · 0 comments
Open

Remove replace directive from go.mod #1482

perdasilva opened this issue Oct 30, 2024 · 0 comments

Comments

@perdasilva
Copy link
Contributor

#1471 was failing on the windows go-releaser gha due to:

# github.com/Microsoft/hcsshim/internal/oc
Error: C:\Users\runneradmin\go\pkg\mod\github.com\!microsoft\[email protected]\internal\oc\errors.go:21:39: undefined: errdefs.ToGRPC

This issues is fixed on v0.12.8 (containerd/containerd#10857).

To get the version bump to pass, I've had to add a replace directive to our go.mod

replace github.com/Microsoft/hcsshim => github.com/Microsoft/hcsshim v0.12.8

We need to remove this when containerd gets bumped again and includes the fixed library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@perdasilva