Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that Title should be max 30 characters long #777

Closed
Popolechien opened this issue May 10, 2023 · 8 comments · Fixed by #1024
Closed

Clarify that Title should be max 30 characters long #777

Popolechien opened this issue May 10, 2023 · 8 comments · Fixed by #1024
Assignees

Comments

@Popolechien
Copy link
Contributor

Creating a zim file whose title is longer than 30 characters will cause the job to crash. This should either be explicitely indicated in the Title field (with a small counter to indicate where one is) or if there is no particular reason for this limit then extend to something along the lines of 60 characters.

@rgaudin
Copy link
Member

rgaudin commented May 10, 2023

The limit is a recommendation of the spec. See log.

We've decided to enforce our own recommendation at scraperlib's level.

What's left is:

  • Update zimfarm to enforce limits at ZF edition level
  • Update the descriptions to indicate the limits.
  • discuss whether there are valid cases –for us– to allow longer Titles.
  • If so, extend scraperlib and the scrapers in question to support it

@Popolechien
Copy link
Contributor Author

Update zimfarm to enforce limits at ZF edition level

This would probably be the most efficient

@rgaudin
Copy link
Member

rgaudin commented May 10, 2023

As explained in another ticket ; we'd still need to discuss and adapt the scrapers that uses dynamic metadata: YT, TED for instance

@kelson42
Copy link
Contributor

@rgaudin

As explained in another ticket ; we'd still need to discuss and adapt the scrapers that uses dynamic metadata: YT, TED for instance

AFAIK this part has been achieved meanwhile. @benoit74 you conform, otherwise can you please list the blocking issues?

@benoit74
Copy link
Collaborator

benoit74 commented Jun 3, 2024

Now TED and Youtube are not creating anymore ZIMs with titles longer than 30 characters, this is true, and this is correct that it should be reflected in the Zimfarm configuration.

We probably have other scrapers in the same situation, to be checked when this issue will be implemented.

I propose to move this to prio1

@benoit74
Copy link
Collaborator

benoit74 commented Jun 3, 2024

(it is already prio1, sorry ^^)

@benoit74
Copy link
Collaborator

Removed from zimit2 project unfortunately

@benoit74
Copy link
Collaborator

benoit74 commented Oct 8, 2024

I've moved the part around displaying current number of characters used in #1025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants