Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we change default log level? #2121

Open
benoit74 opened this issue Dec 27, 2024 · 1 comment
Open

Should we change default log level? #2121

benoit74 opened this issue Dec 27, 2024 · 1 comment
Assignees
Labels

Comments

@benoit74
Copy link
Contributor

Currently, scraper default log level is error meaning mostly no log is produced unless an error occurs.

Probably biased by my own expectations, I feel like this is not a "sensible" default, I would expect most user to be presented sufficient logs by default, to know what the tool is currently doing and potential issues encountered (warnings).

Should the user want more or less logs, he will then find the --verbose setting and customize this log level.

I hence suggest that we change the default log level to log (meaning we will log by default log, warn and error messages).

At least this is not the first time that I come back to this tool, and every-time I struggle to find again the proper way to print more logs on my console.

WDYT?

@benoit74 benoit74 self-assigned this Dec 27, 2024
@audiodude
Copy link
Member

I agree wholeheartedly that the logging needs to be updated. If we change the level to log, I would also want to do an audit of existing messages to keep the logspam down.

Possibly related, I've noticed that there are at least a few places where the code essentially swallows exceptions, by catching the exception, logging a simple message without a stack trace, and then either rethrowing or failing in another way. Fixing these would also help with general debugging when we get errors in zimfarm, because we would be able to see the stack trace in the immediate logs without having to re-run the job manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants