Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we parse the challenges in Python at scrape time? #50

Open
benoit74 opened this issue Dec 17, 2024 · 0 comments
Open

Should we parse the challenges in Python at scrape time? #50

benoit74 opened this issue Dec 17, 2024 · 0 comments
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@benoit74
Copy link
Collaborator

Currently, challenges are parsed in the UI, with JS.

I tend to consider this is a bad thing because:

  • it consumes resources (parsing Markdown ...) client-side, while we know some clients are not really high-end machines
  • it means that should parsing fail, it will be discovered very late (we could even create completely broken ZIMs without noticing if the format changes on freeCodeCamp side)
  • it avoids from making informed decision on what to include inside the ZIM (e.g. remove unsupported challenge types, fail the scrape if there are too many, ...)

What I don't know yet is why freeCodeCamp chose this markdown format. Is it just more convenient / less verbose to write for course developers and an heritage of Gatsby framework they are using? Or is there any painful consequence when transforming it into JSON?

To be investigated

@benoit74 benoit74 added enhancement New feature or request question Further information is requested labels Dec 17, 2024
@benoit74 benoit74 added this to the 2.0.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant