Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP 2.0: Add support for RFC 0317 PleaseAck #1946

Closed
swcurran opened this issue Sep 20, 2022 · 2 comments
Closed

AIP 2.0: Add support for RFC 0317 PleaseAck #1946

swcurran opened this issue Sep 20, 2022 · 2 comments

Comments

@swcurran
Copy link
Contributor

To implement full support for AIP 2.0, we need to add support for RFC0317 Please Ack to ACA-Py. The feature needs to support both types of requested ACKs -- RECEIPT and OUTCOME.

The OUTCOME part of this RFC is tricky, I think. AFAIK, the framework must detect when the "outcome" is produced, which is a context-specific notion, dependent on the protocol being run and the current state of the protocol. I believe (although I'm not sure it is clear in the RFC) that "outcome" means that the state of the protocol proceeds to the next state based on the actions of the recipient of the pleaseAck decorator.

In implementing this feature, those issues must be addressed. It would be nice to have this feature implemented independent of specific protocols -- detected and handled by the protocol manager component. As noted, that is relatively easy to do for a RECEIPT request, but trickier for an OUTCOME.

@swcurran swcurran added this to the 1.0.0 milestone Sep 20, 2022
@swcurran swcurran removed this from the Version 1.0.0 milestone Aug 10, 2023
@alexsdsr
Copy link

alexsdsr commented Oct 9, 2023

Hello @swcurran . I've created a PR (#2540) that could become a start point in the discussion about please_ack support in ACA-Py. I would appreciate if someone takes a look at it. Thanks.

@swcurran
Copy link
Contributor Author

swcurran commented Oct 9, 2023

Thanks — will take a look! @dbluhm FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants