Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation API do not mention label property for dm.Bbox class #1555

Closed
irmo322 opened this issue Jul 5, 2024 · 2 comments
Closed

Documentation API do not mention label property for dm.Bbox class #1555

irmo322 opened this issue Jul 5, 2024 · 2 comments
Assignees

Comments

@irmo322
Copy link

irmo322 commented Jul 5, 2024

Hi,

The documentation shows an example of Bbox instantiation in https://openvinotoolkit.github.io/datumaro/latest/docs/get-started/quick-start-guide/examples.html

import numpy as np
import datumaro as dm

dataset = dm.Dataset.from_iterable([
  dm.DatasetItem(id='image1', subset='train',
    media=dm.Image.from_numpy(data=np.ones((5, 5, 3))),
    annotations=[
      dm.Bbox(1, 2, 3, 4, label=0),
    ]
  ),
  # ...
], categories=['cat', 'dog'])
dataset.export('test_dataset/', 'coco')

What is weird is that there is no mention of the label property in API reference https://openvinotoolkit.github.io/datumaro/latest/docs/reference/_autosummary/datumaro.components.annotation.html#datumaro.components.annotation.Bbox

Without the previous example, there is no way to learn in documentation that Bbox has a label. This is quite confusing for me.

By reading the source code, I see that label is defined in _Shape (parent of BBox), which is not documented.

I suggest to add _Shape properties in Bbox API documentation.

@wonjuleee
Copy link
Contributor

@sooahleex, could you update the document?

@sooahleex
Copy link
Contributor

Hi @irmo322 , Thank you for your interest in our project. We have updated the documentation to include _Shape properties in the annotations. Additionally, the subclasses of _Shape have also been updated. Thank you for bringing this to our attention. If you have any further suggestions, please feel free to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants