Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Library installation fails due to supposedly-missing crti.o #1466

Closed
onkoe opened this issue Apr 21, 2024 · 2 comments
Closed

build: Library installation fails due to supposedly-missing crti.o #1466

onkoe opened this issue Apr 21, 2024 · 2 comments
Assignees
Labels
BUG Something isn't working

Comments

@onkoe
Copy link

onkoe commented Apr 21, 2024

Hi there! Unfortunately, I'm not savvy enough with this library to know what's going on, but for some reason, I'm getting an error when attempting to install this library into a clean virtual environment.

Could you please check the details section and see if anything sticks out to you? The error is related to ld being unable to find crti.o, though that's installed with the glibc-devel package at /usr/lib64/crti.o.

My first thought was to try installing the i686 version of the package (glibc-devel.i686) to place the file at /usr/lib/crti.o, but this also seemed to have no effect.

The build only fails with the older version of pandas. With pandas==2.2.2 in my pyproject.toml, the build goes perfectly. However, that's too new for datumaro and I cannot use the library without the old version (datumaro==1.6.0 depends on pandas>=1.4.0,<1.5.dev0).

Take care,
Barrett

vinnamkim added a commit that referenced this issue Apr 22, 2024
### Summary

- To address #1466

### How to test
Our existing tests can validate the new pandas version

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [ ] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [ ] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```

---------

Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim
Copy link
Contributor

Hi @onkoe,
Thanks for your valuable feedback. I made a fix and it will be included in 1.6.1 which will be released soon. If you found any weakness in this project, please don't hesitate to let us know anytime.

@vinnamkim vinnamkim added the BUG Something isn't working label Apr 22, 2024
@onkoe
Copy link
Author

onkoe commented Apr 23, 2024

Woah, thank you so much for the prompt fix! Excited to get this fantastic library into action. 😄️✨️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants