Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request #7

Open
NobodyXu opened this issue Aug 15, 2022 · 2 comments
Open

Review request #7

NobodyXu opened this issue Aug 15, 2022 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@NobodyXu
Copy link
Member

This crate contains some unsafe code required for efficient io operations, so I'd like your review @jonhoo .
It should be quite easy to review since it only has roughly 800 lines of code.

Some of them (IoSliceExt) might even be qualified to upstream to std library.

@NobodyXu NobodyXu added the help wanted Extra attention is needed label Aug 15, 2022
@jonhoo
Copy link

jonhoo commented Aug 20, 2022

Unfortunately, I don't have the spare cycles at the moment to do a proper review of this at the moment 😞

@NobodyXu
Copy link
Member Author

Unfortunately, I don't have the spare cycles at the moment to do a proper review of this at the moment 😞

Feel free to review it at anytime, though it should not take much time to review this crate because the functions are highly decoupled with relatively few unsafe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

No branches or pull requests

2 participants