Add support on windows #61
Conversation
|
This change is |
NobodyXu
force-pushed
the
support-windows
branch
from
6cd4f6b to
111418e
Compare
|
The Windows CI does not support running docker container, so I didn't run the integration tests on Windows CI. |
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
- tempdir - dirs - libc - once_cell - io-lifetimes - tokio-pipe are now only enabled on unix. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
by marking them `cfg(unix)` or `cfg(not(windows))` Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Accept `tokio::proess::Command` instead of `std::process::Command` Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Since Windows does not support container. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
I copied it from `stdio/unix.rs` and I forgot to change `RawFd` to `RawHandle`. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Remove unused parameter `&self`. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
|
While I appreciate the work you've done on this, I don't think this is something I want to merge. We don't have a reliable way to test it in CI, it introduces a lot of conditional compilation, it has a completely different execution model (which will be unexpected for users), and it will become unsupported again if we eventually move to just supporting the native mux. |
I have to agree, as this makes this crate significantly more complicated and I haven't figure out how to run sshd on windows in the CI yet. IMHO it will be much easier if unix socket in windows supports passing file handler/fd. |
Fixed #46