Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Hook Status Reporting #9260

Closed
pweil- opened this issue Jun 9, 2016 · 7 comments
Closed

Deployment Hook Status Reporting #9260

pweil- opened this issue Jun 9, 2016 · 7 comments

Comments

@pweil-
Copy link
Contributor

pweil- commented Jun 9, 2016

We need a convenient way to see if a hook is running for a deployment and which hook it is. Right now you can see if a pod exists with the deployment name and the suffix but that is not a great way to find out the deployment status.

Since the hook go through an executor maybe we could update status for the deployment there. We should also consider emitting an event.

@Kargakis @jwforres @ironcladlou @mfojtik

@0xmichalis
Copy link
Contributor

Events on the hook executor is a good idea. I have also been thinking about having not only the hooks but also the deployer to have the dc status updated. We will probably need to do it either in #6233 or as a follow-up.

@0xmichalis
Copy link
Contributor

but also the deployer to have the dc status updated

Actually this won't be needed with #9002

  • Deployer pod updates deployment
  • DC controller notices deployment update, resyncs parent config
  • Profit

@mfojtik
Copy link
Contributor

mfojtik commented Jun 21, 2016

@Kargakis do we still think the event is a good idea? I can add one there.

@mfojtik
Copy link
Contributor

mfojtik commented Jun 21, 2016

actually, the hook executor is running independently from the controller, so I don't think we can emit events here.

@0xmichalis
Copy link
Contributor

Yes, events on the hook executor are fine. Not sure if we can enhance the config status to reflect running hooks but that's something we should do upstream first.

@mfojtik
Copy link
Contributor

mfojtik commented Jun 21, 2016

@Kargakis I think events are fine, not sure if we need to update the status, if you want to know when the hooks run, you can just watch the events.

@0xmichalis
Copy link
Contributor

@mfojtik for now yes. Updating the status is an API change that we may want to consider after we move hooks upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants