Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consoles: Extract console tabs into components #2037

Open
enrubio opened this issue Jul 26, 2024 · 2 comments · May be fixed by #2189
Open

Consoles: Extract console tabs into components #2037

enrubio opened this issue Jul 26, 2024 · 2 comments · May be fixed by #2189
Assignees

Comments

@enrubio
Copy link
Member

enrubio commented Jul 26, 2024

This will help with testing the tabs. Mentioned here: #2025 (comment)

@enrubio enrubio self-assigned this Jul 26, 2024
@xkopenreview
Copy link
Collaborator

@enrubio if you don't have time i can work on this

@xkopenreview
Copy link
Collaborator

looks like current handling of AC console for the case of no tab # in url is wrong (although it's working)
the active attribute of the assigned submissions tab is not set correctly
because
default tab id is using ${pluralizeString(submissionName) which usually has first letter capitalized
while activate attribute is comparing it with pluralizeString(submissionName).toLowerCase()

it appears to be working because the condition to render tab content is checking submissionName.toLowerCase()

will be corrected in the console tabs pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants