Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt] Allow returning data when re-ordering data and storing it to disk #673

Open
PGijsbers opened this issue Dec 14, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@PGijsbers
Copy link
Collaborator

Archiving a TODO on the issue tracker instead of in code (#172).

# TODO: provide the possibility to return data even if save is set to false,
# as the client code doesn't want to have to load the data again,
# and may want to benefit from the caching of reordered data for future runs.

I think it's a typo and is meant to say that it would return the data when save is set to True. Currently, in case the data is re-ordered and save=True, it is written to file and the file path is returned. The caller likely then would call the function again so that the data is actually loaded (or load the data from the provided path) -- that's just a lot of extra unnecessary work.

@PGijsbers PGijsbers added the enhancement New feature or request label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant