Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeIntegration false by default in 2021 #194

Open
rdylina opened this issue Aug 15, 2021 · 1 comment
Open

nodeIntegration false by default in 2021 #194

rdylina opened this issue Aug 15, 2021 · 1 comment

Comments

@rdylina
Copy link

rdylina commented Aug 15, 2021

Expected Behavior

[REQUIRED] Describe expected behavior

NodeJS native require() should work in root of index.html

Describe the problem

[REQUIRED] Actual Behavior

require() not a defined function

[REQUIRED] Steps to reproduce the behavior

npm run start, open dev inspection, view console

[REQUIRED] Environment

  • AppAuth-JS version: current version as of 8.15.2021
  • AppAuth-JS Environment (Node, Browser (UserAgent), ...): Electron 12.0.2
  • Source code snippts (inline or JSBin)

Fix is applied to index.ts by making the following change starting on line 27
w = new BrowserWindow(
{
width: 1280, height: 720, icon: 'assets/app_icon.png',
webPreferences: {
nodeIntegration: true,
contextIsolation: false,
}
});

@msm-fc
Copy link

msm-fc commented Aug 16, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants