Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Data Product Parser - Ports reference generation #6

Open
RiccardoAmbrosini opened this issue Jul 25, 2024 · 0 comments
Open

[Bug] Data Product Parser - Ports reference generation #6

RiccardoAmbrosini opened this issue Jul 25, 2024 · 0 comments

Comments

@RiccardoAmbrosini
Copy link

Parser Issue - Ports api link conflicts

While registering a data product to the ODM registry, the server generates a fully qualified name for the api object within a port's promise based on its name and version. The issue is that if on the same registry there are two apis with the same name and version, the linked reference of the api definition will link only the first registered api.

Installation Environment

The registry of ODM is currently deployed on an Azure virtual machine and it is runnining within a Docker container. Version 0.7 is being used.

Expected Behavior

The referenced link in the api definition should be different for two output ports even if the api object of the promise has the same name and version.

Current Behavior

The api definitions links are all linked to the first registered definition of the port.

Possible Solution

The issue is probably within the IdentityStrategyDefault class within the Parser folder. The parser should provide different references based on the fqdn of the port.

Steps to Reproduce

  1. Install 0.7 version of the ODM registry.
  2. Call the endpoint to register the base version of the data product descriptor (you can use the attached file):
    http://{{registry_url}}:8001/api/v1/pp/registry/products
  3. Call the endpoint to register a new data product version, using as body the attached file:
    http://{{registry_url}}:8001/api/v1/pp/registry/products/{dp-id}/versions
  4. Observe the response, and explore the links for the definitions of the promise's apis in the output ports. They have the same FQDN auto-generated, same id and same link. The links are therefore the same for both of the output ports because they have the same name and version, even if the defintion of the apis is different.

Attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants