Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - controlling dimension name in odc.stac.load #179

Open
harryle95 opened this issue Nov 30, 2024 · 2 comments
Open

Feature Request - controlling dimension name in odc.stac.load #179

harryle95 opened this issue Nov 30, 2024 · 2 comments

Comments

@harryle95
Copy link

AFAIK, the dataset is created from mk_dataset function which creates the coordinates from odc.geo.xr.xr_coords. This function allows for controlling the dimension name using the dims parameter, a feature unavailable currently at the loader level. Hoisting this parameter to the level of the load function would provide some control over the unpredictability of the dimension name. I am happy to help implementing this feature if people think this is useful.

@clausmichele
Copy link

I also encountered the same, proposing to use the cube:dimensions extension to get the names when available: #136

@Kirill888
Copy link
Member

@harryle95 we can't keep jamming more and more extra **kwargs into .load, we first need to implement "builder pattern" or maybe "configuration context" kinda thing for configuring various things in a more extensible way first.

@clausmichele I don't think cube extension is relevant here, my understanding of cube extension is about describing "datacube asset", whatever that might be, probably zarr, hdf or parquet, without needing to actually read that information from the file. While this is more like: I want my output to have specific names for spatial coordinates, and I don't want to rename them manually after load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants