Upload directory to s3 is incorrect if destination directory exists

[Kirill888]

This is for branch network-fs-support-newbase, but just to keep track.

When moving temp data from /some/temp_dir/* to s3://bucket/final/destination/ we expect that files from /some/temp_dir/ are copied to s3, but the directory itself is not copied to s3.

https://github.com/GeoscienceAustralia/eo-datasets/blob/075c0e787bc8809d9831afb917de4d4acad7091d/eodatasets3/utils.py#L177

Behaviour of the line above differs depending on whether destination folder exists, at least for s3, but probably for fs as well.

Expected behaviour is equivalent to:

• mkdir -p $FINAL_DIR && cp -r $TMP_DIR/* $FINAL_DIR/

Actual behaviour when $FINAL_DIR exists is:

• cp $TMP_DIR $FINAL_DIR/

which creates extra directory layer under $FINAL_DIR