Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Passing Data to an Interface #536

Open
subbyte opened this issue Jul 9, 2024 · 0 comments
Open

Better Passing Data to an Interface #536

subbyte opened this issue Jul 9, 2024 · 0 comments
Labels
enhancement New feature or request kestrel2 Issue specific to kestrel2 implementation

Comments

@subbyte
Copy link
Member

subbyte commented Jul 9, 2024

Is your feature request related to a problem? Please describe.
Currently, we just pass cache to an interface in evaluation, so the cached variable can be picked up by the interface. I am planning to implement a column lookup function in an interface (for implementing ProjectEntity), which will check the database/datalake table alone the ProjectEntity's trunk using IRGraph.find_datasource_of_node(). However, that method will not stop by Variable and it does not know which Varible to stop (only cached Variable should stop it).

Describe the solution you'd like
Do not pass cache to an interface, instead, add Construct node to the IRGraphEvaluable flowing into cached Variable. In an interface, when the IRGraphEvaluable is evaluated, any Construct will be written into the database/datalake as a table, or handled in memory.

@subbyte subbyte added enhancement New feature or request kestrel2 Issue specific to kestrel2 implementation labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kestrel2 Issue specific to kestrel2 implementation
Projects
None yet
Development

No branches or pull requests

1 participant