Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] Viewport / screen rotation should be disabled on Mobile #221

Open
1 of 5 tasks
willroberts opened this issue Oct 29, 2022 · 1 comment
Open
1 of 5 tasks

[P0] Viewport / screen rotation should be disabled on Mobile #221

willroberts opened this issue Oct 29, 2022 · 1 comment
Labels
bug Something isn't working frontend Related to app / game client code help wanted Extra attention is needed

Comments

@willroberts
Copy link
Collaborator

Summary

The game should always operate in landscape mode. However, mobile browsers support screen rotation. Since this results in a viewport changed (and a forced app reload), let's disable screen rotation.

Impacted services

  • The frontend app
  • The game servers
  • Game builds or automation scripts
  • Tests or Github Actions
  • Infrastructure (Terraform)

Steps to reproduce

  1. Open https://staging.duelyst.org in a mobile browser
  2. Rotate the device

Environment information

  • Operating system: Android
  • Browser: Chrome
  • Browser version: Latest
@willroberts willroberts added the bug Something isn't working label Oct 29, 2022
@willroberts willroberts added help wanted Extra attention is needed frontend Related to app / game client code labels Oct 29, 2022
@KenAKAFrosty
Copy link
Contributor

A UX note: We should allow, encourage even, portrait mode for the login screen, or anywhere where typing is needed.

Once a text input is engaged and the mobile keyboard expands, there's VERY little screen real estate left when in landscape mode. Makes logging in an act of faith.

But otherwise I'm fully behind the idea that when playing the main app, landscape mode is locked in 👍

Related (dont know another good place for this right now): Consider us setting frame rate default to 30 on mobile. It runs a bit rough right now on mobile when playing (I'm on a Google Pixel 3. Not brand new but still a pretty solid device). This may be an easy win for that. Similarly, default to medium quality on mobile perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to app / game client code help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants