Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select a logging framework. #156

Open
bsutton opened this issue Sep 9, 2021 · 4 comments
Open

Select a logging framework. #156

bsutton opened this issue Sep 9, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@bsutton
Copy link
Collaborator

bsutton commented Sep 9, 2021

We really need to look at selecting a logging framework which we use and recommend.

It would be nice if there was something similar to java slf4j-api.logger which is able to work with an array of logging provider. This allows the user to choose their logger and dcli would then log via that provider. This may not be possible without using mirrors which I would prefer to avoid.

Alternativley we could extend the existing setVerbose logging.

@bsutton bsutton added the help wanted Extra attention is needed label Sep 22, 2021
@bsutton
Copy link
Collaborator Author

bsutton commented Sep 22, 2021

Anyone will to have a crack of building/selecting a logging framework that we use/export as part of the dcli package.
Or should we just leave this to the user to choose?

slf4j loggers look problematic as I suspect that java uses reflection.

@passsy
Copy link
Contributor

passsy commented Sep 22, 2021

@jorgecoca @felangel can we do a joined effort and create a new timber/lumberdash without the maintenance trouble?

@felangel
Copy link

@jorgecoca @felangel can we do a joined effort and create a new timber/lumberdash without the maintenance trouble?

I think we need to align on what value this new package would bring over the existing packages.

@bsutton
Copy link
Collaborator Author

bsutton commented Sep 22, 2021

@felangel I think that is a valid concern.

Ideally we should be able to adapt to whatever logger the user chooses.

There would be a significant effort in building and maintaining our own.

One idea is to build a separate set of adaptor packages. One for each of the popular loggers.
The user then adds the appropriate adaptor package to dcli.

bsutton added a commit that referenced this issue Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants