Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to enforce maintainers to have packaging configuration? #71

Open
marimeireles opened this issue Sep 23, 2024 · 5 comments
Open

Comments

@marimeireles
Copy link

I'm trying to setup omero-test-infra in a repository that is not set up to be a python package.
Currently, omero-test-infra requires to be set-up in a repository that contains pyproject.toml or setup.py. Is that a feature or a bug?
It might be good to make project maintainers to setup packages if they want to use this setup, but I'm wondering if that's what we want to do.

@marimeireles
Copy link
Author

Another issue that comes to mind is whether all applications what will depend on this repo are python apps?

@jburel
Copy link
Member

jburel commented Sep 23, 2024

This was mainly developed for our needs and for the needs of members of the community building either Web apps or CLI plugins. Some steps requiring setup.py could easily be ignored depending on the repository using it.
What is the setup of your repository?

@marimeireles
Copy link
Author

It's a bit specific and a bit uncommon I think, but I'm creating an extension for OMERO that uses ontop.
And then got prompted about needing a config file for Python, which didn't make sense in my case, but then I imagined it might be other users since there's a big overlap of this ecosystem with Java, for example.

@jburel
Copy link
Member

jburel commented Nov 13, 2024

Which "stage" are you passing to the test-infra srv and dev do not run Python commands

@joshmoore
Copy link
Member

It might well be that the ontop use case (https://github.com/German-BioImaging/omero-ontop-mappings) needs another stage, @marimeireles like service. i.e., you're going somewhere where no one has gone before ;)

That could possibly then use the docker-compose.yml in your repository as an extension of the main one. That might help to get rid of some of the diff in master...marimeireles:omero-test-infra:master

cc: @CFGrote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants