Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles missing iam:ListAccountAliases causing conflict in profile names #250

Open
ashish-desai-simplisafe opened this issue Oct 29, 2024 · 0 comments

Comments

@ashish-desai-simplisafe

When using '--all-profiles' flag to automatically write all account/role combinations into the credentials file, there is a conflict issue when 2 account have the same role name and those roles don't have the permission 'iam:ListAccountAliases'.
Example:

Account1:
   Role1
   Role2
Account2:
   Role1
   Role2

Assuming Role2 is missing 'iam:ListAccountAliases', the code
webssoauth.go
will write down the profile as
org-Role2
org-Role2
So the credential file will only have the last account it processed and saved under "org-Role2", missing the creds for one of the accounts.

I would suggest that instead of using the "org" prefix to consider using the account number as the prefix.
Eg:
123-Role2
234-Role2
This way both creds will exist instead of getting overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant