Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secret access API added based on renku secrets implementation #271

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

secret access API added based on renku secrets implementation #271

wants to merge 4 commits into from

Conversation

okolo
Copy link
Contributor

@okolo okolo commented Aug 5, 2024

No description provided.

@okolo okolo linked an issue Aug 5, 2024 that may be closed by this pull request
use renku secret storage #261
Open
@okolo okolo requested review from volodymyrss and dsavchenko August 5, 2024 08:41
@okolo okolo added the test-live label Aug 5, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 19.14%. Comparing base (02e47e3) to head (4c13879).

Files with missing lines Patch % Lines
tests/test_secret.py 42.85% 8 Missing ⚠️
oda_api/secret.py 28.57% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (02e47e3) and HEAD (4c13879). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (02e47e3) HEAD (4c13879)
4 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #271       +/-   ##
===========================================
- Coverage   59.00%   19.14%   -39.87%     
===========================================
  Files          23       25        +2     
  Lines        4945     4963       +18     
===========================================
- Hits         2918      950     -1968     
- Misses       2027     4013     +1986

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@volodymyrss
Copy link
Member

Thanks! There is readthedocs in this repo, could you add a section there?

volodymyrss
volodymyrss requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add a doc?

@burnout87 burnout87 mentioned this pull request Aug 12, 2024
Closed
@ferrigno
Copy link
Contributor

ferrigno commented Sep 3, 2024

Note that this PR is already published in docs at https://odahub.io/docs/guide-development/ Please merge it !

@ferrigno ferrigno requested a review from volodymyrss September 3, 2024 09:52
dsavchenko
dsavchenko requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static type checking fails, preventing unit tests from starting. Proposed changes should fix it.

oda_api/secret.py Show resolved Hide resolved
oda_api/secret.py Outdated Show resolved Hide resolved
@dsavchenko
Copy link
Member

Live API tests issue is most likely on the production instance side.

volodymyrss and others added 2 commits September 4, 2024 11:28
@volodymyrss @dsavchenko
Update oda_api/secret.py
c64a6b7 
Co-authored-by: Denys Savchenko <[email protected]>
@volodymyrss @dsavchenko
Update oda_api/secret.py
ee6cd92 
Co-authored-by: Denys Savchenko <[email protected]>
volodymyrss
volodymyrss requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the MyPy check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsavchenko dsavchenko dsavchenko requested changes

@volodymyrss volodymyrss volodymyrss requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
test-live
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use renku secret storage
4 participants
@okolo @volodymyrss @ferrigno @dsavchenko