Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plot_tools.OdaLightCurve more universal #171

Open
dsavchenko opened this issue Nov 30, 2022 · 2 comments
Open

Make plot_tools.OdaLightCurve more universal #171

dsavchenko opened this issue Nov 30, 2022 · 2 comments
Assignees

Comments

@dsavchenko
Copy link
Member

There are a lot of restrictions currently
e.g. in get_lc the RATE column is assumed, whereas data_products.LightCurveDataProduct is meant to be more universal, allowing FLUX, MAG, COUNTS columns

Plotting also seems to work only with src_name meta_data field set in data product; the name of data unit should contain exactly LC, more restrictions may occur.

@volodymyrss @andriineronov here we come back to the +- strict definition of the lightcurve product.

@volodymyrss
Copy link
Member

We can relax assumptions in get_lc etc.

@volodymyrss
Copy link
Member

For every code revision, we can infer that it implements certain standard.

We can even think of it as a a URI constructed like this:

https://github.com/oda-hub/oda_api/blob/ddc67e17afbe6cb9c6caab91ff0e4c3e80ff1194/oda_api/plot_tools.py#OdaLightCurve

each of these https://github.com/oda-hub/oda_api/blob/*/oda_api/plot_tools.py#OdaLightCurve are subClass of https://odahub.io/ontology/#LightCurve . (it should be written in the class I guess)

Currently, https://odahub.io/ontology/#LightCurve is not constraining in ontology. We'll add move properties there.

But it should not prevent you from developing new https://github.com/oda-hub/oda_api/blob/*/oda_api/plot_tools.py#OdaLightCurve as you see fit.

You see, this is a form of language/ontology evolution from ground-up, supported by top-down revisions which is I think more fruitful and actually more life-like than strictly top-down.

(by the way, they can be moved to a different module, plot_tools is no more appropriate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants