You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a lot of restrictions currently
e.g. in get_lc the RATE column is assumed, whereas data_products.LightCurveDataProduct is meant to be more universal, allowing FLUX, MAG, COUNTS columns
Plotting also seems to work only with src_name meta_data field set in data product; the name of data unit should contain exactly LC, more restrictions may occur.
each of these https://github.com/oda-hub/oda_api/blob/*/oda_api/plot_tools.py#OdaLightCurve are subClass of https://odahub.io/ontology/#LightCurve . (it should be written in the class I guess)
Currently, https://odahub.io/ontology/#LightCurve is not constraining in ontology. We'll add move properties there.
But it should not prevent you from developing new https://github.com/oda-hub/oda_api/blob/*/oda_api/plot_tools.py#OdaLightCurve as you see fit.
You see, this is a form of language/ontology evolution from ground-up, supported by top-down revisions which is I think more fruitful and actually more life-like than strictly top-down.
(by the way, they can be moved to a different module, plot_tools is no more appropriate)
There are a lot of restrictions currently
e.g. in
get_lc
the RATE column is assumed, whereasdata_products.LightCurveDataProduct
is meant to be more universal, allowing FLUX, MAG, COUNTS columnsPlotting also seems to work only with
src_name
meta_data field set in data product; the name of data unit should contain exactlyLC
, more restrictions may occur.@volodymyrss @andriineronov here we come back to the +- strict definition of the lightcurve product.
The text was updated successfully, but these errors were encountered: