-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to trigger redeployment of a specific project #35
Comments
Why do you need to trigger, is there some change which is causing the fix? Deployment version can include both repository and bot version, so if bot is improved you can redeploy. If the issue was temporary bot should retry periodically, with a changing period. It's declarative and bot reconciles like flux controllers. |
That's a good idea
It's OK, but I dadn't want the bot to spam the user with "failed" emails. Probably, if the bot sends email only on first failure and then only in case of success, could be the way |
Ideally only system issues would be retried. I.e. issues which could not be interpreted as user-caused container build issues. For these issues user email might not be needed, users can do little with these messages. But if it's hard to distinguish, and anyway, user emails should be throttled as you say, one per failed deployment. |
It's probably possible to distinguish. Kaniko propagates the exit code of the build, and it can be obtained from the failed pod status. When pod is killed due to some platform problem, it most probably will have exit code 137 (but to be explored, ref). If possible exit codes produced by build errors do not fall in >128 range, we can use them to distinguish the cause of the failure. (This is more of a note for myself. All these changes go to nb2workflow) |
If the project failed to deploy, this is written in status and no redeployment attempts are happening until the new commit.
Currently, I sometimes trigger rebuild with an empty commit, but it would be good to have a way to do it without touching the repo. Any ideas @volodymyrss ?
The text was updated successfully, but these errors were encountered: