-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials and token #86
Comments
For now, is there any issue with passing it as an extra parameter? The token will be eventually injected according to oda-hub/nb2workflow#138
For staging, instance, there is no point to synchronize credentials, it's meant to be used for tests. When we move on to have multiple production instances (or decide to consider staging instance one of the production instances) we can adapt different auth infrastructure (it's partially adapted in MMODA already) which will grant authorizations accordingly. This issue is details on one of the use cases described in oda-hub/nb2workflow#138. I will move it. |
No issues in passing it as extra parameter |
If you need to test consistency of credentials, some form of synchronization of credentials is advisable. |
Not sure what you mean here by synchronization. If you mean copying - that's a very bad idea. |
what I mean is that I can have the same roles in different instances and that the token from staging frontend can be used as the token from production frontend to submit jobs to the dispatcher in Geneva using oda_api For testing, it would be maybe enough to have the same roles and these can be updated "by hand" by the user without bothering the administrator (the user is supposed to be a tester in the staging instance). |
I understand what you are trying to achieve, but the outline if the implementation you are suggesting is incomplete and unfeasible. For testing you can keep passing the token since it works for you. |
Not sure if it works, the service never finished when started from the frontend, but I cannot see the execution, so I cannot debug (this is another development, so I will wait patiently). |
What is linked is not just about HPC storage, it's not what it says in the ticket, project, and RFC. Since you are not up to date on this aspect of the project, we can discuss it separately. Anyway, is it urgent for you? What is the time scale? |
It is OK, I can wait:
|
Notebook output IS already implemented. You don't see any output because of the frontend issue, it gets stuck with progress-bar window in case of non-successfull error code from dispatcher (Some of them? Providing some tests for this issue is still in my todo). In this particular case, there is 403 "Not authorised" response. So just rename this parameter somehow and see if it helps.
What will be easy for now is to make some string transformation in the tab generator, e.g. Capitalise the labels and replace underscores with spaces. It will look better in most cases.
With token as input parameter, it wouldn't be complicated to make this form field hidden and populate with the token from user session (Only if token key is shared between instances, of course). |
Indeed, this could be useful (oda-hub/frontend-tab-generator#28) . Then there is #53
It should be just called differently token it's to access to access different platform with difference capacities. |
I can change the name of the token parameter in the notebooks for testing, but if one has to fill the token manually from the UNIGE instance into the French instance the service becomes unusuable. We will need to group all workflows relative to an instrument to a single instance as it would be too confusing for a user to get token for INTEGRAL in Geneva, token for CTA in Lausanne, token for Antares in Paris ... giving stupid examples. |
I don't know what you are trying to say here, I thought we discussed above that ODA token injection (similarly to other credentials and secrets) will be implemented (before December 2024). |
I deployed the latest frontend, and it seems this issue is fixed there. Now the error is clearly returned. |
Thanks Denis. Volodymr, let's talk about this on another day, we are going in round here with my poor understanding of things. |
For the reference: Simply adding token parameter doesn't work oda-hub/frontend-tab-generator#33 |
@okolo can we add a term for specifying dependency on another MMODA? |
In my notebooks, I need to specify a token to upload to the gallery or access private data. Currently, it is a parameter.
By trying another service (nb2w-example), I received the following message
which contains a token with my credentials on the staging instance.
I have two main questions:
The text was updated successfully, but these errors were encountered: