Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 support for ncurses is broken #36

Open
stesachse opened this issue Jun 10, 2018 · 1 comment
Open

utf8 support for ncurses is broken #36

stesachse opened this issue Jun 10, 2018 · 1 comment

Comments

@stesachse
Copy link

in oping.c:923 in has_utf8() the # if HAVE_NCURSESW_NCURSES_H is wrong. in consequence of this hist_symbols_utf8 is not used and the the graph type prettyping is not realy pretty. the name of the header file is curses.h see also oping.c:85 or the third changelog entry from 1997/05/31 😎

diff --git a/src/oping.c b/src/oping.c
index c087c80..7ceb4e0 100644
--- a/src/oping.c
+++ b/src/oping.c
@@ -920,7 +920,7 @@ static void time_calc (struct timespec *ts_dest, /* {{{ */
 #if USE_NCURSES
 static _Bool has_utf8() /* {{{ */
 {
-# if HAVE_NCURSESW_NCURSES_H
+# if HAVE_NCURSESW_CURSES_H
 	if (!opt_utf8)
 	{
 		/* Automatically determine */

works for me on master with fedora 28

@ar1a
Copy link

ar1a commented Jun 11, 2018

I'm getting this also

wfaulk added a commit to wfaulk/liboping that referenced this issue Aug 7, 2019
woodsts pushed a commit to woodsts/buildroot that referenced this issue Dec 30, 2021
Add patch from upstream merge request [1] to fix fix utf8 ncurses
support.

[1] octo/liboping#36

Signed-off-by: Peter Seiderer <[email protected]>
Signed-off-by: Thomas Petazzoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants