Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an exception instead of Failure "execve: Argument list too long" #561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Raise an exception instead of Failure "execve: Argument list too long" #561

wants to merge 1 commit into from

Conversation

Innf107
Copy link

@Innf107 Innf107 commented Jun 19, 2023

Fix #556

@talex5
Copy link
Collaborator

talex5 commented Jun 20, 2023

This string matching looks a bit fragile (OS/locale dependent). Perhaps we should get action_execve to output errno and just match on that (e.g. execve:7:...)?

strerrorname_np is GNU-specific, but we can use caml_unix_error_of_code to convert integer codes to OCaml values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"execve: Argument list too long" should not be a Failure
2 participants
@Innf107 @talex5