Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't absorb KeyedVectors into BaseS2V class #62

Open
oborchers opened this issue Dec 3, 2021 · 0 comments
Open

Don't absorb KeyedVectors into BaseS2V class #62

oborchers opened this issue Dec 3, 2021 · 0 comments
Assignees
@oborchers
Labels
enhancement New feature or request

Comments

@oborchers
Copy link
Owner

Untangling the bad design decision to actually store the BaseKeyedVector from Gensim internally. If users want mmap, they can just load that and pass it. At least we shouldn't store it with the model.
@oborchers oborchers added the enhancement New feature or request label Dec 3, 2021
@oborchers oborchers self-assigned this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oborchers oborchers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oborchers