Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default open serial_numbers and model_numbers #847

Open
tschmidtb51 opened this issue Dec 16, 2024 · 2 comments
Open

Correct default open serial_numbers and model_numbers #847

tschmidtb51 opened this issue Dec 16, 2024 · 2 comments
Assignees
Labels
csaf 2.1 csaf 2.1 work motion_passed A motion has passed

Comments

@tschmidtb51
Copy link
Contributor

During the CSAF workshops, it was brought up that the current wording regarding Model numbers and Serial numbers is unfavorably:

If a part of a [model/serial] number of the component to identify is given, it SHOULD begin with the first character of the [model/serial] number and stop at any point. Characters which SHOULD NOT be matched MUST be replaced by either ? (for a single character) or * (for zero or more characters).
Two * MUST NOT follow each other.

However, this is bad if the format is changed later on, e.g. by appending a character. For example, there is not way to differentiate between 12345 and 123456. Both would match, if the value 12345 was given.

Therefore, we should change the text to not allow stopping at any point without appending the *.

@tschmidtb51
Copy link
Contributor Author

Suggested text:

If a part of a [model/serial] number of the component to identify is given, it SHOULD begin with the first character of the [model/serial] number and end with the last character. Characters which SHOULD NOT be matched MUST be replaced by either ? (for a single character) or * (for zero or more characters).
Two * MUST NOT follow each other.

Conversion rule

  • type /$defs/full_product_name_t/model_number: If a model number is given that does not end on a star, the CSAF 2.0 to CSAF 2.1 converter SHOULD add a * to the end and output a warning that a partial model number was detected and a star has been added. Such a warning MUST include the model number.

A tool MAY provide a non-default option to interpret all model numbers as complete and therefore does not add any stars.

@tschmidtb51 tschmidtb51 added csaf 2.1 csaf 2.1 work motion_passed A motion has passed and removed tc-discussion-needed labels Dec 18, 2024
@sthagen
Copy link
Contributor

sthagen commented Dec 18, 2024

2024-12-18 TC meeting: Thomas Schmidt moved to approve the proposal, Sonny van Lingen seconded, no discussion, unambiguous consent. Motion carried

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csaf 2.1 csaf 2.1 work motion_passed A motion has passed
Projects
None yet
Development

No branches or pull requests

2 participants