Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leapp should warn of bad type used in dialog\answerfile #607

Open
fernflower opened this issue Feb 11, 2020 · 0 comments
Open

leapp should warn of bad type used in dialog\answerfile #607

fernflower opened this issue Feb 11, 2020 · 0 comments
Labels
bug

Comments

@fernflower
Copy link
Member

fernflower commented Feb 11, 2020 •
edited
Loading

Currently it is possible to pass a non-boolean type to a BooleanComponent in a dialog via answerfile and absolutely no warning\report message is shown. How the value will be treated is up to the actor's
logic to decide. I suggest we add some transparency and reporting to the matter.

leapp answer --section remove_pam_pkcs11_module_check.confirm=shouldbeaboolhere 

[remove_pam_pkcs11_module_check]
confirm = shouldbeaboolhere

Actual usage behavior is defined by the actor https://github.com/oamg/leapp-repository/blob/master/repos/system_upgrade/el7toel8/actors/removeoldpammodulescheck/actor.py#L62
@fernflower fernflower added the bug label Feb 11, 2020
@fernflower fernflower changed the title leapp preupgrade warn of bad type used in dialog\answerfile leapp preupgrade should warn of bad type used in dialog\answerfile Feb 11, 2020
@fernflower fernflower changed the title leapp preupgrade should warn of bad type used in dialog\answerfile leapp should warn of bad type used in dialog\answerfile Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fernflower