Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that if you had a separate WSP before, when upgrading, you should configure one locally #2718

Open
didib opened this issue Feb 8, 2022 · 5 comments
Labels

Comments

@didib
Copy link
Member

didib commented Feb 8, 2022

The RHV 4.3 admin guide documented setting up websocket-proxy on a separate machine. Current guides do not.

No guides that I could find documented how to upgrade such a setup. Generally speaking, upgrading the websocket-proxy machine is the same as our general upgrade instructions - add/update repos, update setup packages, run 'engine-setup', update the rest if needed.

I am creating this issue now because I noticed that this flow will likely not work (didn't try, though):

  • Setup <= 4.4.5 engine and websocket-proxy on separate machines
  • Upgrade the engine to 4.5
  • Try using the websocket-proxy without upgrading it

So the upgrade guide should probably also mention:

  • You should upgrade your setup to latest 4.4 before upgrading to 4.5, on all relevant machines
  • If you have <= 4.4.5 websocket-proxy, it will not work with a 4.5 engine

See also:

https://bugzilla.redhat.com/show_bug.cgi?id=1912687
https://bugzilla.redhat.com/show_bug.cgi?id=1912691

@didib didib added the content label Feb 8, 2022
@michalskrivanek
Copy link
Member

note it's been dropped from RHV 4.4 as a feature (since you quote RHV 4.3 doc)

@emarcusRH
Copy link
Contributor

From the release notes (announced in RHV 4.4.4):
BZ#1901073
Support for third party websocket proxy deployment is now deprecated, and will be removed in a future release.

@emarcusRH
Copy link
Contributor

@michalskrivanek the websocket proxy is listed as Technical Preview in the Administration Guide and the Release Notes - is this still correct?

@michalskrivanek
Copy link
Member

it is. the 3rd party deployment is dropped. but the proxy is still there. it's just that we don't need to care about 3rd party upgrades

@didib
Copy link
Member Author

didib commented Feb 9, 2022

I didn't remember that, thanks. Perhaps we should write somewhere that if you had a separate WSP before, when upgrading, you should configure one locally (with --reconfigure-optional-components), if you want to remain "compliant".

That said, not sure what this means in practice. We still support separate dwh+grafana, so almost all of the code required for separate WSP is already "covered" by these. Actually, I think the flow I described above is the quite rare exception.

@sandrobonazzola sandrobonazzola changed the title Separate websocket-proxy is not documented Document that if you had a separate WSP before, when upgrading, you should configure one locally Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants