-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to bubble up Webpack output #349
Comments
+1 on optionally show webpack's output |
any news on this? |
I think the plan is to release kyt 0.4.0 and then look in to upgrading Webpack since there are some potentially breaking changes there. |
We could probably reach into the webpack stats and surface the performance budget to users so that we can avoid all of the other noise that webpack logs. But I'm not sure if kyt is going to need this feature soon. After we land vendor bundling and work on a user manual that better explains the goals behind code splitting in React apps, and since most users probably create projects from our starter kyts, most kyt projects won't need the warnings that this tool provides. Osmani's original rationale behind this feature was to warn users that were likely building a single dist: "we noticed quite a few folks were shipping down monolithic JavaScript bundles." I don't think this will apply to most kyt projects, especially if we're doing a good job of guiding our users. |
Just to follow up here: as discussed in person, it still makes sense to have the option of showing the webpack output (for things like this performance budget and otherwise) because it is still possible to ship down a large JS chunk even if you're code-splitting at the route level. In those cases, having the performance budget warning would indicate to users to code-split within a given route, etc. |
Webpack 2.2 RC
Webpack 2.2 RC includes support for Performance Budgets (also, dynamic imports, etc). However, kyt currently silences webpack's output so users won't be able to take advantage of this feature.
Read more here: https://medium.com/webpack/webpack-performance-budgets-13d4880fbf6d#.da4lr9175
Bug or Feature?
Feature
Current Behavior
Webpack output is swallowed
Desired Behavior
Webpack output is (optionally?) visible
Potential Solutions
kyt.config.js
to bubble up/opt for Webpack's outputI'd suggest
#2
because Webpack's output is much richer than what we currently show. We can still emojify the start/end to communicate clearly to the user what's going on task-wise, but otherwise muting webpack's output seems a disservice, especially given the new Performance Budget feature.Thoughts?
The text was updated successfully, but these errors were encountered: