Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwnsc not terminating after done compiling #41

Open
StefanoND opened this issue Jun 20, 2023 · 3 comments
Open

nwnsc not terminating after done compiling #41

StefanoND opened this issue Jun 20, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@StefanoND
Copy link

Hello, first of all thanks for nwnsc.

I'm using Linux, Manjaro 6.3.5-2 and VSCodium (with marketplace and unblocked features)

I've been using nwnsc with VSCode for a while now and I've always noticed that as time goes on, my computer fans starts ramping up and the entire system starts to slow down to a point where I'm forced to reboot to fix this issue.

Then one day I decided to look into what was causing it, I ran "htop" command in the terminal to check for running processes and noticed that there was a lot of nwnsc instances running.

Since I'm too lazy I just created a script that runs "sudo killall nwnsc" periodically instead of posting the issue here.

So basically everytime nwnsc runs it never terminates it after its done.

Here's a screen snip of my htop

PS: I've already posted an issue in https://github.com/PhilippeChab/nwscript-ee-language-server which is the plugin that I'm using to run it, and the dev said that the issue is not with his plugin but with nwnsc itself (exclusively on linux systems), so that's why I'm posting it here.

Thanks again

image

@jakkn
Copy link
Contributor

jakkn commented Sep 28, 2023

Hi @StefanoND, thank you for the bug report! I can confirm that this happens, and it seems to trigger when something fails to compile.

To reproduce you just need any syntax error. Example:

void main() {
  return
}

I tested a couple different versions and found that v1.1.3 works, while v1.1.4 doesn't.
I also looked over the diff v1.1.3...v1.1.4 but nothing stands out to my untrained eye as breaking.

The next step would be to try to bisect the error, but this project doesn't compile on my system so I'm not going to be of immediate help here. Perhaps @niv or @PhilippeChab can lend a hand as the contributors on v1.1.4 🙏

@jakkn jakkn added bug Something isn't working help wanted Extra attention is needed labels Sep 28, 2023
@PhilippeChab
Copy link
Contributor

The problematic commit would be this one?

@PhilippeChab
Copy link
Contributor

Typo here might be the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants