Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear/wrong behaviour of the ADC converter module #766

Open
fschlueter opened this issue Nov 21, 2024 · 1 comment
Open

Unclear/wrong behaviour of the ADC converter module #766

fschlueter opened this issue Nov 21, 2024 · 1 comment
Assignees

Comments

@fschlueter
Copy link
Collaborator

Hi,

I noticed that in the analogToDigitalConverter module the commit below changed the name of an argument : random_clock_offset to clock_offset and also the "behaviour" of this argument was changed while that was not reflected in the doc-string. I wonder if that change is/was actually desired.

1b08bf1#diff-cd07fb39be6229e4bfade1d415171fe6fff40e6be9343ed3d495544f6529a704

@fschlueter
Copy link
Collaborator Author

Or is that because the function trace_utilities.delay can not handle negative delays?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants