Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitter model "efield_idl1_spice": 'iN' pulse selection variable is not properly set in the simulation even if set in the hdf5 generated data #730

Open
aj-nielsen opened this issue Oct 4, 2024 · 0 comments

Comments

@aj-nielsen
Copy link
Collaborator

In NuRadioMC/simulation/simulation.py, an issue arises specifically with the "efield_idl1_spice" emitter model, where, even if you set the pulse you want to use when you generate data with the iN variable as follows (where nonRandomPulse_number is a variable between 0 and 9):

data_sets["iN"] = nonRandomPulse_number * np.ones(n_events)

...the simulation seems to override the iN input and goes back to randomly picking one of the 10 pulses.

I think this issue is somewhere in lines 835-851 of simulation.py, or otherwise is related to the fact that iN doesn't seem to be passed in as a key to the emitter anywhere even if it's set in the data generation step.

(This is admittedly really niche, and I have a simple hack to get around it for now so it doesn't need a fix urgently. But figured it was worth bringing up anyway, especially since the emitter class is in the main branch now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant