-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface to modify RNO-G detector description #616
Comments
A other possibility is to modify the json file. If that is the case we should add some utility scripts to NuRadio for that. |
I am not sure how the class is structured at the moment but, as a user, I would love to have something that can take a list of electronic elements or response class object and return a |
what about a new class "ModifiedDetector" that inherits from the RNO-G detector but allows the user to overwrite any parameters/response functions? This detector class could also implement other useful functions such as systematically changing response functions to study systematic uncertianties, etc. |
and as always, I would take a pragmatic approach and implement only the functionality that someone needs for their analysis right now. If more functionality is needed at a later stage, this can be added later. |
This was mentioned in one of the RNO-G calls. Several analyses (I guess mostly calibration related) will profit / make it necessary to change the detector description "on-the-fly" to validate the effect on the changed description. I can think of a few approaches how to realise that. This issue is here to collect ideas and as a discussion platform.
I have two ideas:
total_response
of a channel. Keep in mind this key is buffered internally. Also this key is not exported to file (because one can/should not serialise custom classes and the data are already exported).total_reponse
(those would than need to be defined in the database)The text was updated successfully, but these errors were encountered: