Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for calibration pulsers are redundant #564

Open
christophwelling opened this issue Aug 30, 2023 · 0 comments
Open

Unit tests for calibration pulsers are redundant #564

christophwelling opened this issue Aug 30, 2023 · 0 comments
Assignees

Comments

@christophwelling
Copy link
Collaborator

There are currently two unit tests for the calibration pulser example: Test calibration pulser example and Test radio emitter pulser example.
As far as I can tell, both of these tests do the exact same thing, except that one of them compares the results to a reference.
There are also files for a pulser test under NuRadioMC/test/emitter that seem to not be used for anything.

One of the two tests, and any unused files, should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants