Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a github link as pacakge version breaks the @nx/dependecy-checks #29478

Open
1 of 4 tasks
cskiwi opened this issue Dec 27, 2024 · 0 comments
Open
1 of 4 tasks

Using a github link as pacakge version breaks the @nx/dependecy-checks #29478

cskiwi opened this issue Dec 27, 2024 · 0 comments

Comments

@cskiwi
Copy link

cskiwi commented Dec 27, 2024

Current Behavior

hi,

I've just updated from nx 20.1.3 to 20.3.0 and I'm getting a lint error on my packages that use https://docs.sheetjs.com/docs/

there the install method is:
npm i --save https://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz

So this puts it as following in the package.json:

{
 "dependencies": {
    "xlsx": "https://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz"
 }
}

however this throws:
31:5 error The version specifier does not contain the installed version of "xlsx" package: 0.20.3 @nx/dependency-checks

changing the package.json in the libraries to

{
  "peerDependencies": {
    "xlsx": "0.20.3"
  },
}

resolves the issue (the --fix uses the github link as the fix)

Expected Behavior

that the github link is fine

GitHub Repo

No response

Steps to Reproduce

  1. install SheetJS
  2. Use it in a library (which has a packge.json)
  3. Run the lint

Nx Report

Node           : 20.17.0
OS             : win32-x64
Native Target  : x86_64-windows
npm            : 10.8.2

nx                     : 20.3.0
@nx/js                 : 20.3.0
@nx/jest               : 20.3.0
@nx/eslint             : 20.3.0
@nx/workspace          : 20.3.0
@nx/angular            : 20.3.0
@nx/devkit             : 20.3.0
@nx/eslint-plugin      : 20.3.0
@nx/module-federation  : 20.3.0
@nx/nest               : 20.3.0
@nx/node               : 20.3.0
@nx/playwright         : 20.3.0
@nx/vite               : 20.3.0
@nx/web                : 20.3.0
@nx/webpack            : 20.3.0
typescript             : 5.5.4
---------------------------------------
Registered Plugins:
@nx/eslint/plugin
@nx/jest/plugin
@nx/playwright/plugin
@nx/webpack/plugin
---------------------------------------
Community plugins:
@auth0/auth0-angular : 2.2.3
apollo-angular       : 8.0.0
ng-apexcharts        : 1.15.0
ng-process-env       : 16.0.6
ngxtension           : 4.2.0

Failure Logs

Package Manager Version

npm 20.17.0

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant