Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for typescript-eslint@8 #27241

Closed
4 tasks
robertIsaac opened this issue Jul 31, 2024 · 3 comments
Closed
4 tasks

add support for typescript-eslint@8 #27241

robertIsaac opened this issue Jul 31, 2024 · 3 comments
Assignees
Labels
outdated scope: linter Issues related to Eslint support in Nx type: bug

Comments

@robertIsaac
Copy link
Contributor

Current Behavior

when I run npm i @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @typescript-eslint/utils@latest it throw

npm error Could not resolve dependency:
npm error peer @typescript-eslint/parser@"^6.13.2 || ^7.0.0" from @nx/[email protected]
npm error node_modules/@nx/eslint-plugin
npm error   dev @nx/eslint-plugin@"19.5.3" from the root project
npm error   @nx/eslint-plugin@"19.5.3" from @nrwl/[email protected]
npm error   node_modules/@nrwl/eslint-plugin-nx
npm error     @nrwl/eslint-plugin-nx@"19.5.3" from @nx/[email protected].

even if I used -f, the next time I do npm i or npm ci it will fail

Expected Behavior

npm i to execute normally
new projects to come with typescript-eslint version 8

GitHub Repo

No response

Steps to Reproduce

  1. in any nx project run npm i @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @typescript-eslint/utils@latest

Nx Report

Node   : 20.14.0
OS     : win32-x64
npm    : 10.8.2

nx                 : 19.5.3
@nx/js             : 19.5.3
@nx/jest           : 19.5.3
@nx/linter         : 19.5.3
@nx/eslint         : 19.5.3
@nx/workspace      : 19.5.3
@nx/angular        : 19.5.3
@nx/devkit         : 19.5.3
@nx/eslint-plugin  : 19.5.3
@nrwl/tao          : 19.5.3
@nx/web            : 19.5.3
@nx/webpack        : 19.5.3
typescript         : 5.5.4

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

nx should produce new projects using the flat configuration as well

I'm welling to help with a PR, but I think this needs a broader discussions about how exactly should it look
there are many breaking changes especially with flat configuration and I'm not sure what is expected
if you want me to start something and to figure it out overtime I don't mind it and I can start working on it this week but I don't want to open a PR that might not be accepted

@JamesHenry
Copy link
Collaborator

I appreciate the enthusiasm @robertIsaac, I only cut the release for typescript-eslint v8 a couple of hours ago. Please have a little patience, I will work on this very soon

@JamesHenry
Copy link
Collaborator

This should land in Nx 19.7 by the end of the month, you can follow along with #27451 which I have created to avoid the multiple duplicates we currently have open.

The WIP PR is getting very close, so stay tuned. It's not easy because of a large differences in ESLint v9 support across ESLint plugins that Nx sets up for you.

@JamesHenry JamesHenry closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: linter Issues related to Eslint support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants