Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.77.0 build failure #34

Closed
chenrui333 opened this issue Mar 27, 2024 · 4 comments
Closed

rust 1.77.0 build failure #34

chenrui333 opened this issue Mar 27, 2024 · 4 comments

Comments

@chenrui333
Copy link

👋 when upgrading rust to 1.77.0, we ran into some regression build failure as below:

error[E0310]: the parameter type `T` may not live long enough
    --> /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-6f17d22bba15001f/rustc-serialize-0.3.24/src/serialize.rs:1155:5
     |
1155 |     fn decode<D: Decoder>(d: &mut D) -> Result<Cow<'static, T>, D::Error> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |     |
     |     the parameter type `T` must be valid for the static lifetime...
     |     ...so that the type `T` will meet its required lifetime bounds...
     |
note: ...that is required by this bound
    --> /private/tmp/rust-20240322-5607-zxyuuj/rustc-1.77.0-src/library/alloc/src/borrow.rs:180:30
help: consider adding an explicit lifetime bound
     |
1151 | impl<'a, T: ?Sized + 'static> Decodable for Cow<'a, T>
     |                    +++++++++

   Compiling rand v0.4.6
   Compiling crossbeam-epoch v0.8.2
   Compiling miniz_oxide v0.4.4
   Compiling num-iter v0.1.42
For more information about this error, try `rustc --explain E0310`.
error: could not compile `rustc-serialize` (lib) due to 1 previous error

I think a release for this commit would solve the issue.

@not-an-aardvark
Copy link
Owner

Thanks, I've published v2.2.3 with the lockfile update.

@chenrui333
Copy link
Author

Thank you @not-an-aardvark, appreciate it!

@chenrui333
Copy link
Author

@not-an-aardvark can you push the release tag to github as well?
image

@not-an-aardvark
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants