Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect changes to PBXShellScriptBuildPhase during target build up-to-date checking #779

Open
2 tasks
Tracked by #786 ...
lacasseio opened this issue Feb 27, 2023 · 0 comments · Fixed by #807
Open
2 tasks
Tracked by #786 ...
Labels

Comments

@lacasseio
Copy link
Member

lacasseio commented Feb 27, 2023

As a user building Xcode targets using Gradle, I want the Gradle tasks representing the Xcode targets using PBXShellScriptBuildPhase to be out-of-date when its build specification change during an incremental build so I can have accurate feedback.

Open Questions

Preview Give feedback

Acceptance Criteria

  • Changes to the build phase name don't cause the task to be out-of-date. The name of a build phase is only an organizational tool and does not impact the build itself.
  • Any changes to inputPaths
    • Adding a new input path
    • Removing an existing input path
    • Changing the resolved path (any change resulting in the same resolved path should be ignored)
    • Changing the input file (or input directory)
  • Any changes to outputPaths
    • Adding a new output path
    • Removing an existing output path
    • Changing the resolved path (any change resulting in the same resolved path should be ignored)
    • Changing the output file (or output directory)
  • Any changes to shellPath (path only)
  • Any changes to shellScript (content only)
  • Changes to showEnvVarsInLog should not cause the task to be out-of-date.
  • Ignore alwaysOutOfDate (see Support alwaysOutOfDate key on PBXShellScriptBuildPhase #747)
  • Using inputFileListPaths causes the task to always be out-of-date
  • Using outputFileListPaths causes the task to always be out-of-date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant