-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iframe size not initiated before content load #365
Comments
a loading attribute is supported data-featherlight-loading='any html can go here' without this you get the small modal before content is loaded if you add appropriate html to loading you can create an appropriately sized modal e.g.
Or similar html to meet your needs |
I fixed this by defining the size of the Iframe using iframeStyle to add CSS via the style attribute of the iframe tag: If you want to pass it as configuration, its named iFrameStyle:
When adding CSS width and height, the Iframe has this size the moment it appears on screen. |
@PhilippGrashoff what did you do about the inital size of the modal? Also have you noticed there are some inconsistencies between the sizing of the two stages of the featherlight box? Even if I specify
I still see an abrupt transition when the iframe loads and the size of the box is changing. |
@kevin-j-morse unfortunately I did not get a proper solution for that yet. I do not use any loading information and the change of size when the Iframe is completely loaded is not too much in my case. |
Hi.
When you set up
data-featherlight-iframe-width
anddata-featherlight-iframe-height
it should take the size into account when the modal window appears not after the external content is loaded..So first we have the size we want and then content loads in.
The modal container could change the size at first to have the space required for iframe.
The text was updated successfully, but these errors were encountered: