Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processors/awesome-lint/url_check: add an option to only check contents of a diff #77

Open
nodiscc opened this issue Feb 1, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@nodiscc
Copy link
Owner

nodiscc commented Feb 1, 2023

E.g. for https://github.com/awesome-selfhosted/awesome-selfhosted-data/pull/10/files, only files that have changed should be checked.

~/GIT/awesome-selfhosted-data (master *%=)$ git diff master...add-glewlwyd --name-only 
software/glewlwyd.yml
@nodiscc nodiscc added the enhancement New feature or request label Feb 1, 2023
@nodiscc nodiscc added this to the 1.0.0 milestone Feb 1, 2023
@nodiscc nodiscc self-assigned this Feb 1, 2023
@nodiscc nodiscc removed their assignment Apr 15, 2023
@nodiscc nodiscc self-assigned this Jul 16, 2023
@nodiscc nodiscc added the wontfix This will not be worked on label Jul 22, 2023
@nodiscc nodiscc closed this as completed Jul 22, 2023
@nodiscc
Copy link
Owner Author

nodiscc commented Dec 5, 2023

Reopening, as diagnosed in #126

The url_check module should be able to only check URLs in files that were changed between two branches.

Github actions provides environment variables GITHUB_BASE_REF and GITHUB_HEAD_REF which could be passed to the url_check module (e.g. URL_CHECK_BASE_REF=$GITHUB_BASE_REF HEAD_REF=$GITHUB_HEAD_REF hecat --config .hecat/url-check.yml)

@nodiscc nodiscc reopened this Dec 5, 2023
@nodiscc nodiscc modified the milestones: 1.0.0, 1.3.0 Dec 5, 2023
@nodiscc nodiscc removed the wontfix This will not be worked on label Dec 5, 2023
@nodiscc nodiscc removed their assignment Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant