Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Highlighting on Main Codebox #7249

Open
avivkeller opened this issue Nov 20, 2024 · 9 comments
Open

Incorrect Highlighting on Main Codebox #7249

avivkeller opened this issue Nov 20, 2024 · 9 comments
Labels

Comments

@avivkeller
Copy link
Member

URL:

https://nodejs.org/en

Browser Name:

Chrome

Browser Version:

131

Operating System:

Linux

How to reproduce the issue:

When visiting the site, the second line of the main codebox has incorrect highlighting. The text is all grey.

This only applies to this tab, not the others.

image

For comparison, on GFM:

import { createServer } from 'node:http'
@avivkeller avivkeller added the bug label Nov 20, 2024
@avivkeller
Copy link
Member Author

avivkeller commented Nov 20, 2024

Looks like it was caused by c5345f5.

I can spend some time tomorrow looking into this, but if someone wants to go ahead, please be my guest

@TenzDelek
Copy link
Contributor

in local server , It is rendering correctly 🤔
image

@bmuenzenmeyer
Copy link
Collaborator

could it be browser specific?
it is rendering for me correctly

image

Vivaldi 7.0.3495.10 (Stable channel) (arm64)
macOS Version 14.7 (Build 23H124)

@avivkeller
Copy link
Member Author

avivkeller commented Nov 20, 2024

It's rendering correctly for me now too. I'm gonna check the deployments to see when it fixed itself?

@avivkeller
Copy link
Member Author

@avivkeller
Copy link
Member Author

avivkeller commented Nov 20, 2024

It seems intermittent. Right now, In Chrome 131, I am experiencing it on https://nodejs.org/en. (Edit 2min later: Not anymore 🤔)

It seems like a client-side issue, not server-side tho.

@avivkeller
Copy link
Member Author

could it be browser specific?

I don't think so. Look ing at the HTML code, the browser render is matching the HTML shown, probably a Shiki client side issue?

@ovflowd
Copy link
Member

ovflowd commented Nov 22, 2024

Could this be caused by Shiki's JavaScript-based parser versus their WebAssembly one? Or could this even be a Shiki-specific bug?

FYI that Im making local changes to the index page to re-indent things and keep them tight and nice.

@AugustinMauroy
Copy link
Member

if someone still have this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants